Clean up README #239
Clean up README #239
Conversation
Add warning about Lampo forgetting the seed on restart Also fix some typos in log messages
chrisguida
force-pushed
the
cguida/cleanup-readme
branch
from
539d6c8 to
2cf4448
Compare
There was a problem hiding this comment.
Thanks!
ACK 2cf4448
Next time, could you add the changes in separate commits? For example:
- Change the README
- Fix the log typos
This way, if we want to create an LTS version like the kernel, we can cherry-pick the commits easily into another branch without causing a mess of changes. 😸
However, thanks for your typo fixes!
|
Sure! The reason I did it this way is because, since the typos in the log messages were referenced in the README, it seemed weird to fix them in the README, then fix them in the places the README is referencing, in different commits. |
|
Ah make sense! but it is better keep separate also if related, in this way we can cherry-pick just the code that we need |
|
Ok I'll keep that in mind for future contributions, thanks for providing feedback :) |
Clean up README and add warning about Lampo forgetting the seed on restart.
Also fix some typos in log messages.