Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

announce alias to the network #210

Closed
Harshit933 opened this issue Apr 11, 2024 · 0 comments · Fixed by #202
Closed

announce alias to the network #210

Harshit933 opened this issue Apr 11, 2024 · 0 comments · Fixed by #202
Assignees
@vincenzopalazzo
Labels
🦀 - rust Rust related things
Milestone
v24.03

Comments

@Harshit933
Copy link
Collaborator 

          we need to announce this, but looks like I still need to finish some work here https://github.com/vincenzopalazzo/lampo.rs/pull/202

Lets open a issue and keep track of this

Originally posted by @vincenzopalazzo in #203 (comment)
@Harshit933 Harshit933 changed the title we need to announce this, but looks like I still need to finish some work here https://github.com/vincenzopalazzo/lampo.rs/pull/202 announce alias to the network Apr 11, 2024
@Harshit933 Harshit933 added the 🦀 - rust Rust related things label Apr 11, 2024
@vincenzopalazzo vincenzopalazzo self-assigned this Apr 12, 2024
@vincenzopalazzo vincenzopalazzo added this to the v24.03 milestone Apr 12, 2024
vincenzopalazzo added a commit that referenced this issue Apr 14, 2024
@vincenzopalazzo
lampo: announce the alias from config
b9237b9 
Now that we have the possiblity to set the alias inside
the configuration we should also announce it.

Suggested-by: @Harshit933
Link: #210
Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo mentioned this issue Apr 14, 2024
Merged
vincenzopalazzo added a commit that referenced this issue Apr 14, 2024
@vincenzopalazzo
lampo: announce the alias from config
e39f65f 
Now that we have the possiblity to set the alias inside
the configuration we should also announce it.

Suggested-by: @Harshit933
Link: #210
Signed-off-by: Vincenzo Palazzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
🦀 - rust Rust related things
Projects
No open projects
lampo v24.03
Status: Done
Milestone
v24.03
Development

Successfully merging a pull request may close this issue.

adding improvments and also support for bolt12 vincenzopalazzo/lampo.rs
2 participants
@vincenzopalazzo @Harshit933