Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix shipjs action #152

Merged
merged 1 commit into from
Oct 27, 2020
Merged

chore: fix shipjs action #152

merged 1 commit into from
Oct 27, 2020

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Oct 12, 2020

@vinayakkulkarni
Copy link
Owner

vinayakkulkarni commented Oct 20, 2020 •
edited
Loading

@jeetiss can you please rebase so I can merge this?

$ git checkout fix-ship-js && git fetch --all && git rebase upstream/main && git push --force

@vinayakkulkarni vinayakkulkarni self-requested a review October 20, 2020 13:39
vinayakkulkarni
vinayakkulkarni approved these changes Oct 20, 2020
View reviewed changes
Copy link
Owner

@vinayakkulkarni vinayakkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

just rebase once

@vinayakkulkarni vinayakkulkarni added the bug Something isn't working label Oct 20, 2020
@vinayakkulkarni vinayakkulkarni merged commit eb9f59a into vinayakkulkarni:main Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayakkulkarni vinayakkulkarni vinayakkulkarni approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failure in setting npm config in shipjs trigger
2 participants
@jeetiss @vinayakkulkarni