Specify tuspy version explicitly. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 friendly, upload example.
erunion
reviewed
Sep 7, 2018
| @@ -21,7 +21,7 @@ | |||
| # Create a variable with a hard coded path to your file system | |||
| file_name = '<full path to a video on the filesystem>' | |||
|
|
|||
| print 'Uploading: %s' % file_name | |||
| print('Uploading: %s' % file_name) | |||
There was a problem hiding this comment.
Any particular reason for these changes?
There was a problem hiding this comment.
This example wouldn't run in Python 3, because print took on the signature of a functionprint 'lkjds -> print('blah'). This change will function for both 2 && 3.
|
Super cool that tuspy kind of dropped 2.7 support in a Semver patch release. |
erunion
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
uploadexample Python 3 friendly.tuspyback to0.2.1as an exact match.Why:
tuspylibrary changes will not function with Python 2.7 out of the box, without modifications.Tidbits:
tuspyversions>=0.2.2.tuspyversion0.2.1.The difference between them, is the
TusRequest.handleattribute. For0.2.1it is apycurlinstance, which appears to be able to handle unicode characters in a Python2.7string.While the
TusRequest.handleattribute for versions>=0.2.2is anhttp.client.HTTPSConnectioninstance which appears to not function for Python2.X, even if at the IO boundary we specify the file encoding asutf-8.The screenshot below, demonstrates an upload (which was failing in the same manor as various user reports) is now succeeding.
TL;DR This should fix the various user reports that have been received.
@erunion
// #134 #135