Add stubs for the functions expecting a non-empty string #7789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of the |
|
Sorry for not getting back to you earlier on this. Some of the issues you're having on CI is, as @AndrolGenhald has mentionned, due to Psalm considering a pure function that asserts something already known as useless. I didn't thought about that earlier. It will likely need some change in Psalm before we can merge this |
|
4.x branch is closed now as we prepare for the 5.0 release. Please target the master branch instead. |
|
Closing as this targets 4.x which is closed. Please reopen on master going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, see #7770