only return true in Union::is*Type* if there is a single type #6829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a inconsistency I noticed. Union has two sets of useful functions:
has*Type*
andis*Type*
.has
ones checks that the type is in there whileis
ones checks that the only type(s) in the union are of the given type.Before the fix, it allowed for
isEmptyMixed
orisEmpty
to return true forempty-mixed|2
andempty|2
for example. It's quite unlikely this lead to actual bugs because those types are pretty rare, especially in Union with other types, but I didn't want to leave this like that :)