Fix CallMap of PDOStatement for PHP8

[sj-i]

• Fixes https://psalm.dev/r/57f8bc0be4
• The definitions are based on the php-src stub. https://github.com/php/php-src/blob/4bbb98c24fa691c176e403ab00a2fe3dd4224b3e/ext/pdo/pdo_stmt.stub.php
  • The example above is valid on the runtime type checking. https://3v4l.org/ZXfT2
• The internal definitions are changed as of PHP 8.0, though the manual doesn't reflect it.
  • e.g. https://3v4l.org/GRY5F

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/57f8bc0be4

<?php

interface PDOStatementInterface
{
    /**
     * @param int $mode
     * @param mixed ...$args
     * @return array
     */
    public function fetchAll(int $mode = \PDO::ATTR_DEFAULT_FETCH_MODE, ...$args);

}

class PDOStatementExtended extends \PDOStatement implements PDOStatementInterface
{
}

Psalm output (using commit ae172b2):

ERROR: MoreSpecificImplementedParamType - 14:7 - Argument 2 of PDOStatement::fetchAll has the more specific type 'callable|int|string', expecting 'mixed' as defined by PDOStatementInterface::fetchAll

[weirdan]

This would need corresponding changes added to Callmap.php as well.

[sj-i]

... and the fix was wrongly added to 'old' only. Fixed!

[muglug]

Thanks!