Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update master from 5.x #10684

Merged
merged 58 commits into from
Feb 9, 2024
Merged

Update master from 5.x #10684

merged 58 commits into from
Feb 9, 2024

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Feb 9, 2024

  • Fix unstable hasFullyQualified(Interface|Enum)()
  • Reflection may reference interfaces and enums
  • Un-ignore recursiveiteratoriterator::__construct
  • Un-ignore arrayobject::getiterator - appears it's been fixed too
  • Fix test by preloading interface
  • Drop suppression as the method is now used in tests
  • Analyze dynamic static property names
  • Analyze dynamic class const names
  • Fix additional places where base_dir was broken due to missing separator
  • additional places with inconsistent trailing slash
  • fix /src/psalm.xml not removed between tests and remove psalm.xml at the end of tests
  • fix errors output in stdout making test fails with cryptic errors
  • improve getcwd return type
  • improve realpath and readlink return type
  • improve file_put_contents return type
  • Add MissingOverrideAttribute issue
  • Move Override tests to separate file
  • Emit MissingOverrideAttribute
  • Apply suggestions from code review
  • Late binding of enum cases
  • directory_separator optional wrong
  • code review add die to forbidden functions for psalm itself
  • ParseError for dynamic constants before PHP 8.3
  • Test for dynamic enum fetch
  • Suppress UndefinedClass in whatever_exists()
  • Flag stdClass::__construct() calls that have arguments
  • Regression and fail tests
  • Fix parsing magic method annotations
  • Strip callmap prefixes from parameter names
  • Fix ord() has no range constraint on its output #10667
  • Revert partial mistakenly pushed fix
  • Improved Reflection stubs ReflectionParameter::getPosition() is non-negative-int. ReflectionMethod name property is always non-empty-string. ReflectionAttribute::getTarget() returns Attribute::TARGET_* instead of int-mask. Even for attributes of promoted properties (https://3v4l.org/rpM1t). *::getAttributes() always returns a list (https://3v4l.org/LYAMb).
  • Added ReflectionParameter::getPosition to CallMap_historical.php
  • Narrow ord() return type to int<0,255>
  • Fix is_object false positive when 'V as int|stdClass'
  • Fix other assertion errors with union templates
  • Don't show backtrace in InvalidDocblock issue message
  • Support parsing constants in shapes

weirdan and others added 30 commits January 29, 2024 22:42
@weirdan
Fix unstable hasFullyQualified(Interface|Enum)()
67ba758 
Before this change, calling:
```php
$classlikes->hasFullyQualifiedInterfaceName($i); // true
$classlikes->hasFullyQualifiedClassName($i); // false
$classlikes->hasFullyQualifiedInterfaceName($i); // false
```
would result in the last call returning `false`
@weirdan
Reflection may reference interfaces and enums
58b7139
@weirdan
Un-ignore recursiveiteratoriterator::__construct
c935cc3
@weirdan
Un-ignore arrayobject::getiterator - appears it's been fixed too
e876396
@weirdan
Fix test by preloading interface
b2aebd9
@weirdan
Drop suppression as the method is now used in tests
e63db9c
@edsrzf
Analyze dynamic static property names
a66aace
@edsrzf
Analyze dynamic class const names
88c2e00
@kkmuffme
Fix additional places where base_dir was broken due to missing separator
d4a5909 
Improves upon vimeo#10542 and vimeo#10628
@kkmuffme
additional places with inconsistent trailing slash
f185f3d
@kkmuffme
fix /src/psalm.xml not removed between tests and remove psalm.xml at …
47c52ad 
…the end of tests
@kkmuffme
fix errors output in stdout making test fails with cryptic errors
fae1d41
@kkmuffme
improve getcwd return type
d79f772
@kkmuffme
improve realpath and readlink return type
d2e5a07
@kkmuffme
improve file_put_contents return type
41ce826
@edsrzf
Add MissingOverrideAttribute issue
7d07e25
@edsrzf
Move Override tests to separate file
c71ad22
@edsrzf
Emit MissingOverrideAttribute
8396360
@weirdan
Apply suggestions from code review
6d572a6
@weirdan
Late binding of enum cases
52eadab 
Resolves a number of long-standing bugs ('Failed to infer case value ...')

Fixes vimeo#10374
Fixes vimeo#10560
Fixes vimeo#10643
Fixes vimeo#8978
@weirdan
Merge pull request vimeo#10603 from weirdan/fix-existing_whatever-ref…
ddb02b9 
…erences
@kkmuffme
directory_separator optional wrong
ee7187c
@kkmuffme
code review add die to forbidden functions for psalm itself
2008ea0
@edsrzf
ParseError for dynamic constants before PHP 8.3
a827806
@edsrzf
Test for dynamic enum fetch
4cec31e
@weirdan
Merge pull request vimeo#10629 from edsrzf/analyze-dynamic-fetches
c40f232
@weirdan
Merge pull request vimeo#10651 from edsrzf/missing-override
578046d
@weirdan
Merge pull request vimeo#10630 from kkmuffme/additional-fix-for-incon…
5d671a4 
…sistent-basedir
@weirdan
Merge pull request vimeo#10655 from weirdan/late-binding-of-enum-prop…
f40e23f 
…erties
@weirdan
Suppress UndefinedClass in whatever_exists()
b822c33 
Fixes vimeo#7395
issidorov and others added 20 commits February 6, 2024 17:01
@issidorov
Fix parsing magic method annotations
afaaa3d 
Fix parsing for code:

```
/**
 * @method static (string|int)[] getArray()
 * @method static (callable() : string) getCallable()
 */
class MyClass {}
```

Resolved tests:

```
1) testMethodAnnotation with data set "static (string|int)[] getArray()"
2) testMethodAnnotation with data set "static (callable() : string) getCallable()"
```
@weirdan
Strip callmap prefixes from parameter names
1c36da6 
Fixes vimeo#10662
@weirdan
Merge pull request vimeo#10665 from issidorov/parsing-magic-methods
2fc2a37
@weirdan
Merge pull request vimeo#10666 from weirdan/10662-strip-callmap-prefi…
b54e0b2 
…xes-from-parameter-names
@danog
Fix vimeo#10667
7d19f30
@danog
Revert partial mistakenly pushed fix
b42c273 
This reverts commit 7d19f30.
@danog
Merge pull request vimeo#10671 from danog/temp_revert
4a5dbca 
Revert partial mistakenly pushed fix
@vudaltsov
Improved Reflection stubs
07a64f6 
ReflectionParameter::getPosition() is non-negative-int.
ReflectionMethod name property is always non-empty-string.
ReflectionAttribute::getTarget() returns Attribute::TARGET_* instead of int-mask. Even for attributes of promoted properties (https://3v4l.org/rpM1t).
*::getAttributes() always returns a list (https://3v4l.org/LYAMb).
@vudaltsov
Added ReflectionParameter::getPosition to CallMap_historical.php
f9ff9d3
@weirdan
Narrow ord() return type to int<0,255>
f9044cb 
Fixes vimeo#10667
@robchett
Fix is_object false positive when 'V as int|stdClass'
2d48916
@robchett
Fix other assertion errors with union templates
7289f64
@weirdan
Merge pull request vimeo#10676 from weirdan/10667-narrow-ord-return-type
06dbd4e
@weirdan
Merge pull request vimeo#10677 from robchett/template_union_object_in…
aedea60 
…correct_assertions
@weirdan
Don't show backtrace in InvalidDocblock issue message
6b6bed5 
Fixes vimeo#8323
@weirdan
Merge pull request vimeo#10679 from weirdan/8323-dont-show-backtrace-…
f9a2314 
…in-InvalidDocblock-issue-message
@weirdan
Merge pull request vimeo#10091 from vudaltsov/improve-refelection-stubs
fa5f150
@weirdan
Support parsing constants in shapes
2f0b85f 
Fixes vimeo#10669
@weirdan
Merge pull request vimeo#10678 from weirdan/10669-class-consts-in-shapes
ba4e312
@weirdan
Merge branch '5.x' into update-master
e8b73cd
@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Feb 9, 2024
@weirdan weirdan requested review from danog and orklah February 9, 2024 22:38
@weirdan weirdan marked this pull request as ready for review February 9, 2024 23:38
@weirdan weirdan merged commit c03a8a0 into vimeo:master Feb 9, 2024
41 of 42 checks passed
@weirdan weirdan deleted the update-master branch February 9, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danog danog Awaiting requested review from danog

@orklah orklah Awaiting requested review from orklah

Assignees
No one assigned
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@weirdan @bwoebi @danog @edsrzf @kkmuffme @issidorov @vudaltsov @robchett