Fix regression – detect unused params with defaults again

vimeo · Sep 14, 2020 · 7e53865 · 7e53865
1 parent ae4feae
commit 7e53865
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php b/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php
@@ -3265,7 +3265,7 @@ public function getTranslatedFunctionParam(
             $param_type,
             new CodeLocation(
                 $this->file_scanner,
-                $fake_method ? $stmt : $param,
+                $fake_method ? $stmt : $param->var,
                 null,
                 false,
                 !$fake_method

diff --git a/tests/UnusedVariableTest.php b/tests/UnusedVariableTest.php
@@ -2238,6 +2238,11 @@ function f(callable $c): void {
                     );',
                 'error_message' => 'UnusedClosureParam',
             ],
+            'unusedFunctionParamWithDefault' => [
+                '<?php
+                    function foo(bool $b = false) : void {}',
+                'error_message' => 'UnusedParam',
+            ],
         ];
     }
 }