transform: flatten mangler: handle nil subfields #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the FlattenMangler so it doesn't populate intermediate struct-fields
of pointer-type. Since pointerification pretty much always converts
these fields to pointers, this is the common case.
There was a bit of missing accounting, so with two structs:
B.Field3
was always populated with the zero-value, even if bothB.Field3_Field1
andB.Field3_Field2
arenil
.This change fixes the case where all underlying fields are
nil
, andprevents those intermediate fields from getting set to non-
nil
values.