Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous "getHost" implementation. #284

Open
OronNadiv opened this issue Sep 24, 2017 · 5 comments
Open

Asynchronous "getHost" implementation. #284

OronNadiv opened this issue Sep 24, 2017 · 5 comments

Comments

@OronNadiv
Copy link

OronNadiv commented Sep 24, 2017

I need to return the host asynchronously. Currently, it can only be done synchronously.

I would be happy add support for that functionality and submit a PR.
Would you consider merging this change into your next release? If the answer is yes, then let's talk about the implementation details (promises vs callbacks, extending the API vs breaking changes etc...).

Thanks!

@OronNadiv
Copy link
Author

OronNadiv commented Sep 24, 2017

I see that this issue was discussed earlier this year. Is there an ETA for this?
I would be happy to help with the implementation if needed.

@monkpow
Copy link
Collaborator

monkpow commented Sep 28, 2017

Hey @OronNadiv, I like the general shape of this change, but I'm curious if you could help me by describing your use case.

Resolving the proxy host and forward path is now handled async (and that's the discussion you're referring to)

Can you tell me more about this case so I can reason through the solution?

Thanks a lot.

@devalexqt
Copy link

For my case, I need check DB by requested file ID, and select proper host for proxy to server where file is stored.

maxstrauch added a commit to maxstrauch/express-http-proxy that referenced this issue Dec 21, 2018
@maxstrauch
Copy link

I really need this feature, so I created a PR with the relevant changes. There are only three places which are changed. So could one of the project owners please merge this into the master and publish it to npm so that I can use the module normally?

@bconnorwhite
Copy link

#420 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants