feat(amazonq): /doc: add support for infrastructure diagrams #1
Conversation
vikshe
force-pushed
the
features/infra-d
branch
2 times, most recently
from
b64edd6 to
4a69a9e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vikshe
force-pushed
the
features/infra-d
branch
2 times, most recently
from
f536bac to
341ca89
Compare
| @@ -363,7 +364,9 @@ export class PrepareCodeGenState implements SessionState { | |||
| this.config.workspaceRoots, | |||
| this.config.workspaceFolders, | |||
| action.telemetry, | |||
| span | |||
| span, | |||
| new AdmZip(), | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vikshe
force-pushed
the
features/infra-d
branch
from
341ca89 to
99a05a3
Compare
vikshe
changed the title
vikshe
force-pushed
the
features/infra-d
branch
from
99a05a3 to
fb11511
Compare
| function isInfraDiagramFile(relativePath: string) { | ||
| return ( | ||
| relativePath.toLowerCase() === 'infra.dot' || | ||
| relativePath.toLowerCase().endsWith('/infra.dot') || |
There was a problem hiding this comment.
relativeFilePath on windows might use backwards slashes
vikshe
force-pushed
the
features/infra-d
branch
4 times, most recently
from
a832ae6 to
98c2fa2
Compare
vikshe
force-pushed
the
features/infra-d
branch
from
98c2fa2 to
ad1b18a
Compare
| @@ -26,6 +30,15 @@ export async function checkForDevFile(root: string) { | |||
| return hasDevFile | |||
| } | |||
|
|
|||
| function isInfraDiagramFile(relativePath: string) { | |||
| return ( | |||
| relativePath.toLowerCase().endsWith('docs/infra.dot') || | |||
There was a problem hiding this comment.
path.join could be used here instead
| // We only respect gitignore file rules if useAutoBuildFeature is on, this is to avoid dropping necessary files for building the code (e.g. png files imported in js code) | ||
| const files = await collectFiles(repoRootPaths, workspaceFolders, true, maxRepoSizeBytes, !useAutoBuildFeature) | ||
| if (!useAutoBuildFeature) { | ||
| if (isIncludeInfraDiagram) { |
There was a problem hiding this comment.
is there a way we could avoid the additional special case logic here? could we either a) remove svg from the exclude patterns, or b) pass in true for defaultExcludePatterns (like /dev does with useAutoBuildFeature). with the addition of isIncludeInfraDiagram its hard to follow all the different scenarios
| } | ||
| export type CollectFilesFileFilter = (relativePath: string) => boolean // returns true if file should be filtered out | ||
|
|
||
| export async function collectFiles2( |
There was a problem hiding this comment.
The name of this function doesn't add value, why is there a second collect files function? take a look at naming section in docs/CODE_GUIDELINES.md
There was a problem hiding this comment.
It looks like the intention here is to have collectFiles use a labeled options object instead of individual parameters, if thats the case, perhaps collectFiles itself should be changed instead of adding a new function
Amazon Q /doc: Add support for infrastructure diagrams
feature/xbranches will not be squash-merged at release time.