fix: refactoring and bug fixes

vighnesh153 · Nov 9, 2024 · 400fb45 · 400fb45
1 parent 7afb8c6
commit 400fb45
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 25 deletions.
diff --git a/tools-nodejs/api-vighnesh153/package-lock.json b/tools-nodejs/api-vighnesh153/package-lock.json
diff --git a/tools-nodejs/api-vighnesh153/package.json b/tools-nodejs/api-vighnesh153/package.json
@@ -35,8 +35,8 @@
     "@types/aws-lambda": "^8.10.145",
     "@types/cookie": "^0.6.0",
     "@types/node": "*",
-    "@vighnesh153/tools": "npm:@jsr/vighnesh153__tools@^0.1.12",
-    "@vighnesh153/tools-server": "npm:@jsr/vighnesh153__tools-server@^0.1.4",
+    "@vighnesh153/tools": "npm:@jsr/vighnesh153__tools@^0.1.13",
+    "@vighnesh153/tools-server": "npm:@jsr/vighnesh153__tools-server@^0.1.5",
     "@vighnesh153/tsconfig": "0.4.8",
     "cookie": "^1.0.1",
     "sst": "^3.2.70",

diff --git a/tools-nodejs/api-vighnesh153/src/common/dynamo_db_table_metadata.ts b/tools-nodejs/api-vighnesh153/src/common/dynamo_db_table_metadata.ts
@@ -1,7 +1,4 @@
-import type {
-  DynamoTypeMap,
-  TableMetadata,
-} from "@vighnesh153/tools-server/aws_dynamodb";
+import type { DynamoTypeMap } from "@vighnesh153/tools-server/aws_dynamodb";
 
 export const userInfoFields = /* @__PURE__ */ {
   userId: "string",
@@ -11,19 +8,13 @@ export const userInfoFields = /* @__PURE__ */ {
   createdAtMillis: "number",
 } satisfies Record<string, keyof DynamoTypeMap>;
 
-export const UserInfoTableMetadata = /* @__PURE__ */ {
-  fields: userInfoFields,
-} satisfies Partial<TableMetadata>;
-
 export const filesMetadataFields = /* @__PURE__ */ {
   fileId: "string",
   filePath: "string",
   mimeType: "string",
   fileSizeInBytes: "number",
   createdAtMillis: "number",
   createdBy: "string",
+  // whether the file is uploaded at this filePath
+  isUploaded: "boolean",
 } satisfies Record<string, keyof DynamoTypeMap>;
-
-export const FilesMetadataTableMetadata = /* @__PURE__ */ {
-  fields: filesMetadataFields,
-} satisfies Partial<TableMetadata>;
diff --git a/tools-nodejs/api-vighnesh153/src/createUploadPresignedUrl/controller.ts b/tools-nodejs/api-vighnesh153/src/createUploadPresignedUrl/controller.ts
@@ -158,7 +158,7 @@ export async function controller({
     const fileExtension = file.fileExtension.length > 0
       ? `.${file.fileExtension}`
       : "";
-    const filePath = `/${mediaType}/id${fileExtension}`;
+    const filePath = `/${mediaType}/${id}${fileExtension}`;
     return {
       clientSideId: file.clientSideId,
       fileId: id,
@@ -226,6 +226,7 @@ export async function controller({
       createdBy: metadata.createdBy,
       createdAtMillis: metadata.createdAtMillis,
       fileSizeInBytes: metadata.fileSizeInBytes,
+      isUploaded: false,
     })),
   });
 

diff --git a/tools-nodejs/api-vighnesh153/src/googleAuthCallback/controller.test.ts b/tools-nodejs/api-vighnesh153/src/googleAuthCallback/controller.test.ts
@@ -12,12 +12,12 @@ import { FakeDynamoDBTable } from "@vighnesh153/tools-server/aws_dynamodb";
 
 import { controller } from "./controller.ts";
 import { FakeUserInfoDecoder } from "../common/user_info_decoder.ts";
-import { UserInfoTableMetadata } from "../common/dynamo_db_table_metadata.ts";
+import { userInfoFields } from "../common/dynamo_db_table_metadata.ts";
 import { FakeCookieSerializer } from "../common/cookie_serializer.ts";
 
 let fakeUserInfoDecoder: FakeUserInfoDecoder;
 let fakeUserInfoTable: FakeDynamoDBTable<{
-  fields: (typeof UserInfoTableMetadata)["fields"];
+  fields: typeof userInfoFields;
   tableName: "fake-user-info";
 }>;
 let fakeCookieSerializer: FakeCookieSerializer;