This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Trigger loadstart #356
Merged
Trigger loadstart #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The swf will no longer emit a loadstart event when it is running in "data generation mode"
|
LGTM |
|
@dmlap LGTY? |
|
@imbcmdth What version of the SWF is this tied to? Are we pointing to the right video.js version in our package.json to pick that up? |
|
Found it. Dependent on videojs/video-js-swf@08fa8f1 |
Events (loadstart, loadedmetadata) are no longer emitted by the swf when used with contrib-hls
imbcmdth
added a commit
that referenced
this pull request
Aug 11, 2015
Trigger loadstart ourselves since the swf will no longer do that
This was referenced Aug 11, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swf will no longer emit a loadstart event when it is running in "data generation mode" so lets do it ourselves!