Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

make sure text tracks added by hls are properly disposed #1228

Merged
merged 1 commit into from
Aug 9, 2017
Merged

make sure text tracks added by hls are properly disposed #1228

merged 1 commit into from
Aug 9, 2017

Conversation

mjneil
Copy link
Contributor

@mjneil mjneil commented Aug 9, 2017

True for the second parameter for addRemoteTextTrack means you must manually cleanup the track, and false is for auto cleanup. These tracks were mistakenly using the api in the opposite way

gesinger
gesinger reviewed Aug 9, 2017
View reviewed changes
Copy link
Contributor

@gesinger gesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I'd add is one more test to ensure the segment-metadata track is cleaned up.

gesinger
gesinger approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@gesinger gesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, it does ensure segment-metadata is removed.

@mjneil mjneil merged commit 03bb285 into videojs:master Aug 9, 2017
@mjneil mjneil removed the in progress label Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gesinger gesinger gesinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjneil @gesinger