chore: fix xvfb in travis config, patch safari karma launchers #5755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Jan 15, 2019
| @@ -67,6 +67,7 @@ | |||
| "docs:fix": "remark --output -- './{,!(node_modules)/**/}!(CHANGELOG)*.md'", | |||
| "docs:lang": "node build/translations.js", | |||
| "netlify": "babel-node ./build/netlify-docs.js", | |||
| "prepare": "patch-package", | |||
There was a problem hiding this comment.
prepare runs before packing the package when when npm install is run without anything https://docs.npmjs.com/misc/scripts
gkatsev
changed the title
|
mojave is a lot stricter about where you can open files from without user interaction and travis got updated to a mojave version with this restriction. We watch to patch the karma-safari-launcher and karma-safaritechpreview-launcher to look for an approved place on mojave when it exists. |
misteroneill
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that we are having some trouble using xvfb on travis. I could not find any issues/blog posts related to this, but I noticed that the docs have changed for its usage. This fix has already been used in the generator and appears to have fixed the issue.