Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: suppress console warnings in Chrome on mobile when scrubbing progress slider #5219

Merged
merged 1 commit into from
Jun 5, 2018
Merged

fix: suppress console warnings in Chrome on mobile when scrubbing progress slider #5219

merged 1 commit into from
Jun 5, 2018

Conversation

bcdarius
Copy link
Contributor

@bcdarius bcdarius commented May 30, 2018 •
edited
Loading

Description

A proposed solution for #4650

Specific Changes proposed

Instead of calling preventDefault() on touchstart in Chrome, set touch-action: none style on progress control to prevent unintended scrolling.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gkatsev
gkatsev approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@gkatsev gkatsev added needs: LGTM Needs one or more additional approvals tested labels Jun 5, 2018
@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Jun 5, 2018
@gkatsev gkatsev merged commit 59869b9 into videojs:master Jun 5, 2018
gkatsev pushed a commit that referenced this pull request Jun 5, 2018
@bcdarius @gkatsev
fix(slider): suppress console warnings in Chrome for Android when scr…
4d9a6ae 
…ubbing (#5219)

Instead of calling preventDefault() on touchstart in Chrome, set touch-action: none style on progress control to prevent unintended scrolling.

Fixes #4650.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
confirmed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcdarius @gkatsev @brandonocasey