Use fonts 2.0 that don't require wrapping codepoints #3252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1 @@ | |||
| $icon-codepoints: true; | |||
There was a problem hiding this comment.
Removing this file entirely would technically be a breaking change, even removing icon-codepoints could be questionable but I don't think many people have been using it.
There was a problem hiding this comment.
Agreed, don't really think this is a problem
gkatsev
added
minor
|
LGTM, makes the code a lot cleaner :) |
|
Very nice, LGTM. Agree that while it could be construed as a (very edge-casey) breaking change, it's not significant enough to merit a 6.0 👍 |
|
I'll just revert the change if anyone complains. |
gkatsev
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The title says it all