Checking instanceof Arrays cross frames (needed for the vjs.Player.prototype.src method)

[shmulik]

vjs.Player.prototype.src uses the instanceof Array method.
This will not work for arrays created on another frame,
Instead of instanceof we should use Array.isArray, but this is not supported on IE8.
So vjs.obj.isArray shim was created for the isArray method.

[gkatsev]

You need to use single quotes, which is why the build failed on travis.

[gkatsev]

Other than that, looks good.

Are there any other cases of foo instanceof Array in the code base? Maybe hunt those down as well?

[shmulik]

Thanks @gkatsev.
So I guess I need to make another pull request....
I did not find another instanceof Array in the code base

[gkatsev]

So I guess I need to make another pull request....

Nope. Just do another commit to the same branch and this PR will pick it up and re-run the build.

I did not find another instanceof Array in the code base

Cool. That's fine.

[heff]

Great stuff! Thanks @shmulik.

We do need to add tests to finish this off, but that shouldn't be too difficult for this. The tests would be added to the test/unit/lib.js file.

You can follow how some of the other tests are written to get started. I think we would need at least two assertions here.

• Check that an array is appropriately identified as an array
• Check that an object is not identified as an array

Would you be up for doing that?

[gkatsev]

Can you also do the same replacement for the instanceof Array here.

While we're at it, we also probably want to do a similar thing to objects:

video.js/src/js/player.js

Line 1109 in 46aa551

} else if (source instanceof Object) {

[heff]

Good find.

we also probably want to do a similar thing to objects

should we just be using typeof source === 'object' there instead?

[gkatsev]

no, because if source is null, it will fail.
We also want to do the toString.call trick for objects as well.

[heff]

We also want to do the toString.call trick for objects as well

Except that won't work if the source object is a source element.

Object.prototype.toString.call(document.createElement('source'));
--> "[object HTMLSourceElement]"

Either way, if @shmulik doesn't want to take on the object piece for this specific issue we can create a new issue for.

[gkatsev]

Yep, that can be done in a different commit. The component piece, might as well be done here as well :D

[heff]

Yeah, the instance of Array in Component should be updated here

[shmulik]

Sorry for my late response, I am on a different time zone.....
I will take care for the instanceof Array in component.js.(missed it somehow)
And will take a look at using a similar trick for objects

[shmulik]

I will also do the tests for the isArray, but only for arrays created on the same frame. Is this good enough?

[shmulik]

@gkatsev , @heff

What do you say about the following code for the Object trick:

vjs.obj.isObject = function(obj) {
return Object.prototype.toString.call(obj) === '[object Object];
};

vjs.obj.isSourceObject = function(src) {
return vjs.obj.isObject(src) || Object.prototype.toString.call(src) === '[object HTMLSourceElement]'
}

[heff]

Yeah, same frame is fine.

---

Steve Heffernan (mobile)

On May 19, 2014, at 9:04 PM, shmulik [email protected] wrote:

I will also do the tests for the isArray, but only for arrays created on the same frame. Is this good enough?

—
Reply to this email directly or view it on GitHub.

[heff]

We need to think a little more on where and how we'd use the object one because I don't think it's the right fit for that specific instance.

---

Steve Heffernan (mobile)

On May 19, 2014, at 10:19 PM, shmulik [email protected] wrote:

@gkatsev , @heff

What do you say about the following code for the Object trick:

vjs.obj.isObject = function(obj) {
return Object.prototype.toString.call(obj) === '[object Object];
};

vjs.obj.isSourceObject = function(src) {
return vjs.obj.isObject(src) || Object.prototype.toString.call(src) === '[object HTMLSourceElement]'
}

—
Reply to this email directly or view it on GitHub.

[heff]

Merged in. Thanks!