Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player#reset does not dispose cached sources. #5675

Closed
misteroneill opened this issue Dec 12, 2018 · 0 comments · Fixed by #5676
Closed

Player#reset does not dispose cached sources. #5675

misteroneill opened this issue Dec 12, 2018 · 0 comments · Fixed by #5676

Comments

@misteroneill
Copy link
Member

Description

Player#reset does not dispose cached sources.

Steps to reproduce

  1. Create a player and set a source
  2. Call player.reset()
  3. Check the output of player.currentSources() or other source-getter methods

Results

Expected

Should see the null-equivalent return value (e.g. [] for currentSources())

Actual

See the cached sources

Error output

None
@misteroneill misteroneill mentioned this issue Dec 12, 2018
Merged
2 tasks
gkatsev pushed a commit that referenced this issue Jan 3, 2019
@misteroneill @gkatsev
fix: make sure sources, volume, and playback rate are reset along wit…
4c9e09d 
…h the player (#5676)

Clear out the player cache_ on reset.

Fixes #5675
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make sure sources, volume, and playback rate are reset along with the player videojs/video.js
1 participant
@misteroneill