You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After implementation of feat: unmute goes back to previously selected volume, there are a couple edge cases in which unmuting will restore the volume from zero to a lower value than a user would probably anticipate or want:
User drags volume to zero twice in a row. In this situation, unmuting sets the volume to the last value it had before reaching zero on the second drag (i.e., something extremely close to zero).
User steps volume to zero with keyboard after adjusting with mouse. The keyboard steps the volume in increments of 0.1, so if the user sets the volume to 0.91 with the mouse, then steps to zero with the keyboard, then unmutes, the volume will be 0.01.
It's unlikely that a user who is trying to unmute by clicking MuteToggle would ever want to set the volume to such a low value as 0.01. Enforcing a minimum volume after unmuting would ensure that doesn't happen. Two important considerations occur to me in thinking about what the value of the minimum should be:
In the situations where this is an issue, the user has actively chosen to set the volume very low before muting (or has actually muted before muting).
If the minimum is higher than the volume a user has chosen for listening, they will no longer be able to toggle between their chosen volume and zero by clicking MuteToggle.
Given those things, I'd suggest 0.1 as the minimum.
Thoughts? If the maintainers agree with this approach, I'd be happy to make a PR.
The text was updated successfully, but these errors were encountered:
After implementation of
feat: unmute goes back to previously selected volume
, there are a couple edge cases in which unmuting will restore the volume from zero to a lower value than a user would probably anticipate or want:It's unlikely that a user who is trying to unmute by clicking
MuteToggle
would ever want to set the volume to such a low value as 0.01. Enforcing a minimum volume after unmuting would ensure that doesn't happen. Two important considerations occur to me in thinking about what the value of the minimum should be:MuteToggle
.Given those things, I'd suggest 0.1 as the minimum.
Thoughts? If the maintainers agree with this approach, I'd be happy to make a PR.
The text was updated successfully, but these errors were encountered: