Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum volume after unmuting #4054

Closed
kevinlitchfield opened this issue Feb 10, 2017 · 0 comments
Closed

Minimum volume after unmuting #4054

kevinlitchfield opened this issue Feb 10, 2017 · 0 comments

Comments

@kevinlitchfield
Copy link
Contributor

After implementation of feat: unmute goes back to previously selected volume, there are a couple edge cases in which unmuting will restore the volume from zero to a lower value than a user would probably anticipate or want:

  1. User drags volume to zero twice in a row. In this situation, unmuting sets the volume to the last value it had before reaching zero on the second drag (i.e., something extremely close to zero).
  2. User steps volume to zero with keyboard after adjusting with mouse. The keyboard steps the volume in increments of 0.1, so if the user sets the volume to 0.91 with the mouse, then steps to zero with the keyboard, then unmutes, the volume will be 0.01.

It's unlikely that a user who is trying to unmute by clicking MuteToggle would ever want to set the volume to such a low value as 0.01. Enforcing a minimum volume after unmuting would ensure that doesn't happen. Two important considerations occur to me in thinking about what the value of the minimum should be:

  • In the situations where this is an issue, the user has actively chosen to set the volume very low before muting (or has actually muted before muting).
  • If the minimum is higher than the volume a user has chosen for listening, they will no longer be able to toggle between their chosen volume and zero by clicking MuteToggle.

Given those things, I'd suggest 0.1 as the minimum.

Thoughts? If the maintainers agree with this approach, I'd be happy to make a PR.

gkatsev pushed a commit that referenced this issue Mar 24, 2017
If, when unmuting, the last volume is below 0.1, force it to be 0.1.

Fixes #4054.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant