Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disposing of the flash tech quickly leaves video.js in a bad state #1339

Closed
dmlap opened this issue Jul 9, 2014 · 1 comment
Closed

Disposing of the flash tech quickly leaves video.js in a bad state #1339

dmlap opened this issue Jul 9, 2014 · 1 comment
Labels
bug confirmed

Comments

@dmlap
Copy link
Member

dmlap commented Jul 9, 2014

Steps to reproduce:

  1. Create a player with techOrder ['flash', 'html5'] but no sources and no data-setup
  2. Initialize video.js manually: videojs(video)
  3. Immediately set an html5-compatible source: player.src({ src: 'movie.mp4', type: 'video/mp4' })

If the Flash tech is disposed of before the ready callback, Component removes the orphaned placeholder div, not the object element. That causes the object element to remain in the DOM after the new tech has been loaded and things get even more crazy once the ready handler finally fires.
dmlap added a commit to dmlap/video.js that referenced this issue Jul 9, 2014
@dmlap
Track the object element during init and remove it if the tech is dis…
da19fa3 
…posed before onReady. For videojs#1339.

If dispose() was called before the SWF triggered onReady(), the placeholder div would be cleaned up but the actual object element would be left behind to mess things up in the future. Keep track of the object element during initialization and make sure it is removed if flash is unloaded early.
@dmlap dmlap mentioned this issue Jul 9, 2014
Merged
dmlap added a commit to dmlap/video.js that referenced this issue Jul 9, 2014
@dmlap
Force add dist files
da370ca 
Temporary fix for videojs#1339
@mmcc mmcc added bug labels Jul 11, 2014
@heff
Copy link
Member

heff commented Jul 28, 2014

closed by #1340

@heff heff closed this as completed Jul 28, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heff @dmlap @mmcc