Skip to content

Commit

Permalink
Only rely on selectedIndex to set select option.
Browse files Browse the repository at this point in the history
Firefox recently added selectedOptions support, however, unlike chrome
and other browsers, they made it read-only and have it throw an error.
In my testing (via http://jsfiddle.net/vwvdywf9/), on various browsers and platforms, just using selectedIndex was sufficient to change the selected option.

closes #1877
  • Loading branch information
gkatsev authored and heff committed Feb 20, 2015
1 parent 8b0966c commit 14c9456
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ CHANGELOG

## HEAD (Unreleased)
* @gkatsev fixed the track list reference while switching techs that use emulated tracks ([view](https://github.com/videojs/video.js/pull/1874))
* @gkatsev fixed a Firefox error with the captions settings select menu options ([view](https://github.com/videojs/video.js/pull/1877))

--------------------

Expand Down
4 changes: 0 additions & 4 deletions src/js/tracks/text-track-settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,6 @@
}
}

if (target.selectedOptions) {
target.selectedOptions[0] = option;
}

target.selectedIndex = i;
}

Expand Down

0 comments on commit 14c9456

Please sign in to comment.