This repository was archived by the owner on Dec 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NishanthJKumar
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after last couple minor comments addressed! Great work - really exciting to see the codebase this mature!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves PGMax to a functional interface.
Main changes to the interface (resolves #82):
init_msgs
fromFactorGraph
and rely on a member function (run_bp
) to run belief propagation, we derive an immutableFactorGraphState
based on added factors to a factor graph, and use theFactorGraphState
to initialize aBPState
.BP
function then takes aBPState
and generates 3 pure functions:run_bp
, which takes log_potentials/ftov_msgs/evidence updates specified in regular python dictionaries, and outputs aBPArrays
containing results after BP.get_bp_state
which constructs aBPState
from aBPArrays
get_beliefs
which calculates beliefs from aBPArrays
.The functional approach allows easy use of regular function transformations in JAX like
vmap
,grad
. Seeexamples/ising_model.py
andexamples/rbm.py
for some added examples on usingvmap
andgrad
with the new functional interface. Resolves #68.Also made various refactors/cleanups (e.g. for unit tests/docstrings/naming, etc.). Resolves #75. Resolves #71.