This repository was archived by the owner on Dec 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Example notebook with PMAP sampling of RBMs trained on MNIST digits #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2021
Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, but 1 potentially-important comment about dependencies and another more minor comment about testing. Will approve after these are addressed/replied to!
NishanthJKumar
approved these changes
Oct 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing the previous comments so quickly 😄
Looks like the use of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the first todo in #77. Also includes a simple change with which we can index 1D variable arrays with integers (instead of length 1 tuples).
Currently a lot of time is spent on graph construction (adding factors and constructing factor wirings) since PGMax is not making use of any of the structures present in an RBM.
In the future, to improve usability, it would be helpful to:
Separately, it would be helpful to introduce a pure functional interface so that we can leverage functionalities like
vmap
in JAX (which would allow us to parallelize sampling multiple digits in this use case). Connected to #68See below for some example samples


: