Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Hotfix for variable number of states #144

Merged
merged 3 commits into from
May 19, 2022

Conversation

antoine-dedieu
Copy link
Contributor

@antoine-dedieu antoine-dedieu commented May 19, 2022

Fixing two minor issues when running BP with variable groups defined with different number of states

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #144 (4ecdd02) into master (1570a1f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          949       949           
=========================================
  Hits           949       949           
Impacted Files Coverage Δ
pgmax/vgroup/varray.py 100.00% <ø> (ø)
pgmax/__init__.py 100.00% <100.00%> (ø)
pgmax/vgroup/vdict.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1570a1f...4ecdd02. Read the comment docs.

Copy link
Contributor

@StannisZhou StannisZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a simple unit test that would catch this earlier, and bump up the version for another release?

Copy link
Contributor

@StannisZhou StannisZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing!

@antoine-dedieu antoine-dedieu merged commit 7c71b14 into vicariousinc:master May 19, 2022
@antoine-dedieu antoine-dedieu deleted the hotfix branch May 19, 2022 19:09
@antoine-dedieu antoine-dedieu changed the title Hotfix Hotfix for variable number of states May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants