This repository was archived by the owner on Dec 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Modules reorganization #140
Merged
antoine-dedieu
merged 3 commits into
vicariousinc:master
from
antoine-dedieu:restructuration
May 3, 2022
Merged
Modules reorganization #140
antoine-dedieu
merged 3 commits into
vicariousinc:master
from
antoine-dedieu:restructuration
May 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StannisZhou
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can further shorten Variable
to Var
and Enumeration
to Enum
. Two other minor comments. Otherwise LGTM!
pgmax/factor/enum.py
Outdated
@@ -42,7 +43,7 @@ def __post_init__(self): | |||
|
|||
|
|||
@dataclass(frozen=True, eq=False) | |||
class EnumerationFactor(nodes.Factor): | |||
class EnumerationFactor(factor.Factor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shorten to EnumFactor
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 20 +7
Lines 916 951 +35
=========================================
+ Hits 916 951 +35
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizes the internal structure of the repo before releasing the new version