Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Modules reorganization #140

Merged
merged 3 commits into from
May 3, 2022

Conversation

antoine-dedieu
Copy link
Contributor

@antoine-dedieu antoine-dedieu commented May 2, 2022

Reorganizes the internal structure of the repo before releasing the new version

@antoine-dedieu antoine-dedieu changed the title WIP - Restructuration Modules reorganization May 3, 2022
Copy link
Contributor

@StannisZhou StannisZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can further shorten Variable to Var and Enumeration to Enum. Two other minor comments. Otherwise LGTM!

@@ -42,7 +43,7 @@ def __post_init__(self):


@dataclass(frozen=True, eq=False)
class EnumerationFactor(nodes.Factor):
class EnumerationFactor(factor.Factor):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorten to EnumFactor

@StannisZhou StannisZhou marked this pull request as ready for review May 3, 2022 05:42
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #140 (5adb0be) into master (dfc7535) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #140   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        20    +7     
  Lines          916       951   +35     
=========================================
+ Hits           916       951   +35     
Impacted Files Coverage Δ
pgmax/factor/__init__.py 100.00% <100.00%> (ø)
pgmax/factor/enum.py 100.00% <100.00%> (ø)
pgmax/factor/factor.py 100.00% <100.00%> (ø)
pgmax/factor/logical.py 100.00% <100.00%> (ø)
pgmax/fgraph/__init__.py 100.00% <100.00%> (ø)
pgmax/fgraph/fgraph.py 100.00% <100.00%> (ø)
pgmax/fgroup/__init__.py 100.00% <100.00%> (ø)
pgmax/fgroup/enum.py 100.00% <100.00%> (ø)
pgmax/fgroup/fgroup.py 100.00% <100.00%> (ø)
pgmax/fgroup/logical.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc7535...5adb0be. Read the comment docs.

@antoine-dedieu antoine-dedieu merged commit c62b624 into vicariousinc:master May 3, 2022
@antoine-dedieu antoine-dedieu deleted the restructuration branch May 3, 2022 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants