This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix offsets computation for messages/potentials; Support AND factor #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoine-dedieu
approved these changes
Mar 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 857 856 -1
=========================================
- Hits 857 856 -1
Continue to review full report at Codecov.
|
| ] | ||
| ) | ||
| num_parents = len(self.variables) - 1 | ||
| relevant_state = (-self.edge_states_offset + 1) / 2 |
There was a problem hiding this comment.
Suggested change
| relevant_state = (-self.edge_states_offset + 1) / 2 | |
| relevant_state = (-self.edge_states_offset + 1) // 2 |
| parents_edge_states[ii, 1] contains the message index of the parent variable's relevant state. | ||
| For ORFactors the relevant state is 0, for ANDFactors the relevant state is 1. | ||
| Both indices only take into account the LogicalFactors of the FactorGraph | ||
| The parent variable's other state is parents_edge_states[ii, 2] + edge_states_offset |
There was a problem hiding this comment.
Suggested change
| The parent variable's other state is parents_edge_states[ii, 2] + edge_states_offset | |
| The parent variable's other state is parents_edge_states[ii, 1] + edge_states_offset |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages and potentials offsets for factors/factor groups should not be done by type, since they are only used in updating messages/potentials which works with the whole flat array. This PR fixes it.
Also added support for AND factors by slightly tweaking the existing OR factor implementation.
Resolves #125