Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Support python 3.9/3.10; Improve documentation for add_factor; Bump up version for new release #120

Merged
merged 16 commits into from
Feb 19, 2022

Conversation

StannisZhou
Copy link
Contributor

@StannisZhou StannisZhou commented Feb 19, 2022

Will make a new release after this PR is merged so that people can use the package under python 3.9/3.10.

@nathanielvirgo I made some updates to the documentation for add_factor. Feel free to leave comments if the description is still not clear.

Resolves #115. Resolves #117

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #120 (f8b81fb) into master (f7f3e3f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #120   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          640       671   +31     
=========================================
+ Hits           640       671   +31     
Impacted Files Coverage Δ
pgmax/fg/graph.py 100.00% <ø> (ø)
pgmax/__init__.py 100.00% <100.00%> (ø)
pgmax/fg/nodes.py 100.00% <0.00%> (ø)
pgmax/fg/groups.py 100.00% <0.00%> (ø)
pgmax/bp/bp_utils.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f3e3f...f8b81fb. Read the comment docs.

Copy link
Contributor

@NishanthJKumar NishanthJKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

@StannisZhou StannisZhou merged commit 716abd6 into vicariousinc:master Feb 19, 2022
@StannisZhou StannisZhou deleted the python branch February 19, 2022 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.9 and 3.10 Incomplete documentation for add_factor
3 participants