[RSDK-9887] get agent config from app #417
Merged
+139
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjperez
commented
Feb 18, 2025
mattjperez
commented
Feb 18, 2025
mattjperez
commented
Feb 18, 2025
mattjperez
commented
Feb 19, 2025
gvaradarajan
requested changes
Feb 19, 2025
acmorrow
approved these changes
Feb 20, 2025
micro-rdk/src/common/config.rs
Outdated
| pub struct NetworkSetting { | ||
| ssid: String, | ||
| password: String, | ||
| priority: usize, |
There was a problem hiding this comment.
I believe priority is permitted to be negative, so I don't think a usize is the right type.
micro-rdk/src/common/config.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct AgentConfig { |
There was a problem hiding this comment.
I have a slight preference for having the struct be introduced before any impl blocks for it. Could you move this up above line 26 please?
| }); | ||
|
|
||
| let version_info = Some(VersionInfo { | ||
| agent_running: "none".to_string(), |
There was a problem hiding this comment.
What happens if we just don't set agent_running?
micro-rdk/src/common/app_client.rs
Outdated
| id: self.robot_credentials.robot_id.clone(), | ||
| host_info, | ||
| version_info, | ||
| subsystem_versions: Default::default(), |
There was a problem hiding this comment.
Could you eliminate even namign this field in favor of ..Default::default()
micro-rdk/src/common/config.rs
Outdated
| impl TryFrom<&DeviceAgentConfigResponse> for AgentConfig { | ||
| type Error = AttributeError; | ||
| fn try_from(value: &DeviceAgentConfigResponse) -> Result<Self, Self::Error> { | ||
| if let Some(ref additional_networks) = value.additional_networks { |
There was a problem hiding this comment.
Instead of ref, could you do value.additional_networks.as_ref() or &value.additional_networks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 of 2 PRs to getting agent config from app (this PR) and storing them in NVS (next PR).
Still cleaning things up (getting rid of unwraps, etc), but wanted to get a first review going already in case there are major design changes requested.