Update Mac CI image #3708
Merged
Update Mac CI image #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
uniform_int_distributionunit tests no longer hang on MacOS 12Description
As noted in https://github.com/actions/virtual-environments#available-environments, the MacOS image we are using for Github Actions,
macos-10.15, is deprecated. Github has started turning it off occasionally to annoy us enough to switch, and it is due to go away entirely sometime in August.I tried
macos-11, and ran into a Clang crash when buildingaligner.cpp, which I think we never fixed and just waited for Clang to fix it in the new Clang version that runs on MacOS 12.On
macos-12, I have the build successfully building, but running the unit tests appears to hang. I need to see if I can reproduce this hang on an interactive machine somewhere, so I can try to fix it.