Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct explicit-constructor clang warning #431

Merged
merged 2 commits into from
Nov 2, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion encfs/XmlReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class XmlNode : virtual public XmlValue {
const tinyxml2::XMLElement *element;

public:
XmlNode(const tinyxml2::XMLElement *element_)
explicit XmlNode(const tinyxml2::XMLElement *element_)
: XmlValue(safeValueForNode(element_)), element(element_) {}

~XmlNode() override = default;
Expand Down
4 changes: 2 additions & 2 deletions encfs/autosprintf.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ class autosprintf {
/* Destructor: frees the temporarily allocated string. */
~autosprintf();
/* Conversion to string. */
operator char*() const;
operator std::string() const;
explicit operator char*() const;
explicit operator std::string() const;
/* Output to an ostream. */
friend inline std::ostream& operator<<(std::ostream& stream,
const autosprintf& tmp) {
Expand Down