Improve logging #296
Merged
Improve logging #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when syslog is used
This was referenced Mar 9, 2017
Closed
|
@rfjakob could we think about merging this easy PR please ? Many thx 👍 |
rfjakob
requested changes
Apr 2, 2017
encfs/main.cpp
Outdated
| @@ -190,6 +191,7 @@ static bool processArgs(int argc, char *argv[], | |||
| out->isVerbose = false; | |||
| out->idleTimeout = 0; | |||
| out->fuseArgc = 0; | |||
| out->syslogTag.assign("encfs"); | |||
There was a problem hiding this comment.
Maybe a stupid question, but why not simply
out->syslogTag = "encfs";
There was a problem hiding this comment.
Because option p) some lines below uses assign :)
I updated with = which is more convenient 👍
encfs/main.cpp
Outdated
| @@ -265,6 +269,9 @@ static bool processArgs(int argc, char *argv[], | |||
| case 'S': | |||
| out->opts->useStdin = true; | |||
| break; | |||
| case 't': | |||
| out->syslogTag.assign(optarg); | |||
rfjakob
approved these changes
Apr 2, 2017
|
When is 1.9.2 going to be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR does 2 things :
-toption to tune syslog tag.Thank you 👍
Ben