-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the blocking time of the write lock when deleting space #5754
Conversation
When the number of parts of a space is relatively large and the amount of data written is also large, it will block for a long time in the removeSpace function when deleting the space. Affect business read and write
Reduce the blocking time of the write lock when deleting space
Wow, thanks @flymysql for the great contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~ Thx
Resolve compilation issues
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5754 +/- ##
==========================================
+ Coverage 77.04% 78.25% +1.20%
==========================================
Files 1133 1133
Lines 85975 85994 +19
==========================================
+ Hits 66243 67291 +1048
+ Misses 19732 18703 -1029
☔ View full report in Codecov by Sentry. |
Cheers! @critical27 @flymysql @SuperYoko |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#5755
Description:
When the number of parts of a space is relatively large and the amount of data written is also large, it will block for a long time in the removeSpace function when deleting the space. Affect business read and write
How do you solve it?
Shorten the range of holding locks
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: