Fix undefined parameter #5404
Merged
Fix undefined parameter #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
force-pushed
the
fix/lookup-undifined-parameter
branch
3 times, most recently
from
7bb5bb6 to
e7943e2
Compare
czpmango
requested review from
jievince,
Shylock-Hg and
yixinglu
and removed request for
Shylock-Hg
czpmango
added
ready-for-testing
Fix tck Fix tck small skip for ldbc tck fmt
czpmango
force-pushed
the
fix/lookup-undifined-parameter
branch
from
7eab1d6 to
2217400
Compare
czpmango
added
ready-for-testing
jievince
previously approved these changes
Mar 16, 2023
Aiee
reviewed
Mar 16, 2023
jievince
previously approved these changes
Mar 17, 2023
jievince
approved these changes
Mar 17, 2023
yixinglu
approved these changes
Mar 17, 2023
| std::accumulate(++undefinedParams.begin(), | ||
| undefinedParams.end(), | ||
| *undefinedParams.begin(), | ||
| [](auto& lhs, auto& rhs) { return lhs + ", " + rhs; })); |
There was a problem hiding this comment.
u could use folly::join to concat the string array 😂
There was a problem hiding this comment.
std::accumulate is also okey, folly lib sounds a little heavy.
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Sep 14, 2023
* Fix undefined parameter Fix tck Fix tck small skip for ldbc tck fmt * small change * Fix error message * small change Co-authored-by: kyle.cao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
https://github.com/vesoft-inc/nebula-ent/issues/2485
Checklist:
Tests:
Affects: