Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph profiling data format #4895

Merged
merged 4 commits into from
Nov 17, 2022
Merged

Fix graph profiling data format #4895

merged 4 commits into from
Nov 17, 2022

Conversation

yixinglu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Return the valid profiling JSON format to client

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added type/enhancement Type: make the code neat or more efficient ready-for-testing PR: ready for the CI test labels Nov 17, 2022
@yixinglu yixinglu force-pushed the format-profile-detail branch from a044abf to 141135a Compare November 17, 2022 05:55
@Shylock-Hg
Copy link
Contributor

Could add test?

@yixinglu yixinglu force-pushed the format-profile-detail branch 2 times, most recently from 5bb5685 to ed9937a Compare November 17, 2022 07:28
@yixinglu yixinglu force-pushed the format-profile-detail branch from 18ede94 to 1a0562c Compare November 17, 2022 10:39
@yixinglu yixinglu merged commit 1aee962 into master Nov 17, 2022
@yixinglu yixinglu deleted the format-profile-detail branch November 17, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants