Fix two crash issues caused by the optimizer's filter push-down rules

[xtcyclist]

What type of PR is this?

• bug
• feature
• enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close https://github.com/vesoft-inc/nebula-ent/issues/1580
Close https://github.com/vesoft-inc/nebula-ent/issues/1683

Description:

• colNames[i] runs out-of-range in PrunPropertiesVisitor.cpp, caused by errors in PushFilterDownAggregateRule & PushFilterDownFilterRule.
• colNames becomes larger than groupItems in PushFilterDownAggregateRule, causing groupItems[i] to run out-of-range.

How do you solve it?

• Check range sizes in for loop in PrunPropertiesVisitor.cpp.
• Found the reason why the sizes differ in PushFilterDownAggregateRule and PushFilterDownProjectRule. Try fixing the exchange of operators.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Design-wise, these two structures that shall have the same size belong to different classes: one in the base class, the other in a derived class. They are manipulated independently in many places, directly or indirecly, causing their sizes to differ. If these structures have to be declared in different classes, maybe we could try grouping modifications on them together in the same method. This may prevent such issues at the first place.

Checklist:

Tests:

• Unit test(positive and negative cases)
• Function test
• Performance test
• TCK

Affects:

• Documentation affected (Please add the label if documentation needs to be modified.)
• Incompatibility (If it breaks the compatibility, please describe it and add the label.）
• If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
• Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

[codecov-commenter]

Codecov Report

Base: 76.78% // Head: 76.85% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (0649363) compared to base (6f240e3).
Patch coverage: 74.85% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4864      +/-   ##
==========================================
+ Coverage   76.78%   76.85%   +0.06%     
==========================================
  Files        1102     1102              
  Lines       80953    81067     +114     
==========================================
+ Hits        62160    62302     +142     
+ Misses      18793    18765      -28     

Impacted Files	Coverage Δ
src/graph/context/Symbols.cpp	91.78% <ø> (ø)
src/graph/executor/admin/SubmitJobExecutor.cpp	56.94% <ø> (ø)
.../graph/executor/algo/MultiShortestPathExecutor.cpp	98.55% <ø> (ø)
...timizer/rule/OptimizeEdgeIndexScanByFilterRule.cpp	87.67% <ø> (-6.93%)	⬇️
src/graph/planner/Planner.h	100.00% <ø> (ø)
src/graph/planner/match/MatchPathPlanner.cpp	98.52% <ø> (ø)
src/graph/planner/plan/PlanNode.h	89.42% <ø> (-0.40%)	⬇️
src/graph/validator/ACLValidator.h	89.65% <ø> (ø)
src/graph/validator/MatchValidator.cpp	89.39% <ø> (+1.32%)	⬆️
src/meta/processors/admin/AdminClient.cpp	63.99% <ø> (ø)
... and 63 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[xtcyclist]

I added the fix (PushFilterDownAggregateRule.cpp:97) to another issue (https://github.com/vesoft-inc/nebula-ent/issues/1683) in this PR, since they are concerning the same code segment in PushFilterDownAggregateRule.cpp.

[yixinglu]

Excellent!!