Better error msg for validity check of geography #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
force-pushed
the
better-err-msg-for-geo
branch
from
d505057 to
97fbc07
Compare
jievince
force-pushed
the
better-err-msg-for-geo
branch
from
0328443 to
4e0490c
Compare
jievince
force-pushed
the
better-err-msg-for-geo
branch
3 times, most recently
from
ae4fc8c to
e21f053
Compare
Aiee
previously approved these changes
Sep 5, 2022
jievince
changed the title
jievince
changed the title
Shylock-Hg
reviewed
Sep 5, 2022
| @@ -2511,7 +2511,8 @@ FunctionManager::FunctionManager() { | |||
| if (!args[0].get().isGeography()) { | |||
| return Value::kNullBadType; | |||
| } | |||
| return args[0].get().getGeography().isValid(); | |||
| auto status = args[0].get().getGeography().isValid(); | |||
| return status.ok() ? true : false; | |||
There was a problem hiding this comment.
It seems doesn't affect.
There was a problem hiding this comment.
Missed it here, thanks
czpmango
reviewed
Sep 6, 2022
jievince
force-pushed
the
better-err-msg-for-geo
branch
from
d394c6e to
4a07114
Compare
Aiee
approved these changes
Sep 6, 2022
czpmango
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
When geography dataum is found to be illegal, print the specific cause of the error to facilitate troubleshooting.
eg.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: