Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case for bugfix https://github.com/vesoft-inc/nebula/issues/4417 #4517

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Aug 12, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #4417

Description:

This problem has been fixed in the master branch

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Aiee Aiee added ready-for-testing PR: ready for the CI test ready for review labels Aug 12, 2022
@Aiee Aiee requested review from Shylock-Hg and jievince August 12, 2022 09:44
@Shylock-Hg
Copy link
Contributor

Please attach the result of explain.

@Aiee
Copy link
Contributor Author

Aiee commented Aug 12, 2022

Please attach the result of explain.

Done.

@codecov-commenter
Copy link

Codecov Report

Merging #4517 (5d7efae) into master (9204b88) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4517      +/-   ##
==========================================
+ Coverage   84.65%   84.70%   +0.05%     
==========================================
  Files        1346     1346              
  Lines      134256   134257       +1     
==========================================
+ Hits       113649   113717      +68     
+ Misses      20607    20540      -67     
Impacted Files Coverage Δ
src/graph/session/GraphSessionManager.h 87.50% <0.00%> (-12.50%) ⬇️
src/kvstore/wal/WalFileIterator.cpp 64.40% <0.00%> (-4.24%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 78.62% <0.00%> (-3.75%) ⬇️
src/graph/executor/query/IndexScanExecutor.cpp 86.48% <0.00%> (-2.71%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 87.23% <0.00%> (-2.13%) ⬇️
src/common/meta/ServerBasedSchemaManager.cpp 84.37% <0.00%> (-1.95%) ⬇️
src/common/base/Status.h 90.56% <0.00%> (-1.89%) ⬇️
src/codec/RowReaderWrapper.h 95.08% <0.00%> (-1.64%) ⬇️
src/storage/admin/AdminTaskManager.cpp 80.80% <0.00%> (-1.61%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Sophie-Xie Sophie-Xie merged commit 2767a00 into vesoft-inc:master Aug 15, 2022
@Aiee Aiee deleted the add-case branch August 15, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to query based on the list of vi'd's returned by the split function
6 participants