Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 'stop job' work as expected #4460

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Jul 25, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

We support stop job, but some kind of jobs are not actually stopped, this PR will report if it is not supported and make the stoppable one work as expected.

Before:
image

After:
image

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 requested review from liwenhui-soul and panda-sheep and removed request for liwenhui-soul July 25, 2022 10:54
@critical27 critical27 added ready-for-testing PR: ready for the CI test ready for review and removed ready-for-testing PR: ready for the CI test ready for review labels Jul 25, 2022
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Sophie-Xie Sophie-Xie merged commit 21ee515 into vesoft-inc:master Aug 1, 2022
@critical27 critical27 deleted the fix branch August 1, 2022 10:57
@critical27 critical27 mentioned this pull request Oct 18, 2022
11 tasks
@foesa-yang foesa-yang self-assigned this Oct 24, 2022
@foesa-yang foesa-yang added the doc affected PR: improvements or additions to documentation label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants