Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore order while comparing nested json objects. #4441

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

xtcyclist
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4425, #4426, #4427, #4428

Description:

GCC-compiled and CLANG-compiled versions generate the same logical query plans with different orders of properties. While comparing query plans, orders of properties shall be ignored.

How do you solve it?

add an option 'ignore_order = True' in deepdiff

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist added the ready-for-testing PR: ready for the CI test label Jul 18, 2022
@Sophie-Xie Sophie-Xie requested review from dutor and Shylock-Hg July 19, 2022 01:09
@Sophie-Xie Sophie-Xie merged commit b83b3ad into vesoft-inc:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants