Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments of error code #4201

Merged
merged 2 commits into from
Apr 24, 2022
Merged

Add comments of error code #4201

merged 2 commits into from
Apr 24, 2022

Conversation

Sophie-Xie
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

@forest-yuxl add comments of error code for doc, and I just added it to the code comments.
https://docs.nebula-graph.io/master/20.appendix/error-code/

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

None

@Sophie-Xie Sophie-Xie requested a review from a team as a code owner April 22, 2022 09:02
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Apr 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4201 (e2f5a88) into master (4112c7d) will increase coverage by 0.07%.
The diff coverage is 98.81%.

@@            Coverage Diff             @@
##           master    #4201      +/-   ##
==========================================
+ Coverage   84.91%   84.98%   +0.07%     
==========================================
  Files        1321     1323       +2     
  Lines      131235   131269      +34     
==========================================
+ Hits       111434   111560     +126     
+ Misses      19801    19709      -92     
Impacted Files Coverage Δ
src/graph/planner/match/MatchClausePlanner.h 100.00% <ø> (ø)
src/graph/scheduler/Scheduler.h 100.00% <ø> (ø)
src/graph/validator/MatchValidator.h 100.00% <ø> (ø)
src/graph/planner/match/MatchClausePlanner.cpp 73.80% <85.71%> (-22.23%) ⬇️
src/graph/planner/match/SegmentsConnector.cpp 98.63% <95.23%> (-1.37%) ⬇️
src/graph/planner/match/MatchPathPlanner.cpp 98.93% <98.93%> (ø)
src/graph/context/ast/CypherAstContext.h 100.00% <100.00%> (ø)
src/graph/planner/match/ArgumentFinder.cpp 90.47% <100.00%> (ø)
src/graph/planner/match/LabelIndexSeek.cpp 98.10% <100.00%> (-0.04%) ⬇️
src/graph/planner/match/MatchPathPlanner.h 100.00% <100.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d124f2...e2f5a88. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants