Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just report error of property prune in debug #4142

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

jievince
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4140

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince added ready-for-testing PR: ready for the CI test cherry-pick-v3.1 PR: need cherry-pick to this version labels Apr 12, 2022
@jievince jievince changed the title Dont report error for the special edge name * during the process of property pruner Just report error of property prune in debug Apr 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4142 (a1a14df) into master (03605d0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4142      +/-   ##
==========================================
+ Coverage   84.95%   85.00%   +0.04%     
==========================================
  Files        1324     1324              
  Lines      131961   131961              
==========================================
+ Hits       112109   112172      +63     
+ Misses      19852    19789      -63     
Impacted Files Coverage Δ
src/graph/optimizer/Optimizer.cpp 94.91% <100.00%> (ø)
src/kvstore/wal/WalFileIterator.cpp 64.40% <0.00%> (-4.24%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 59.20% <0.00%> (-2.15%) ⬇️
src/kvstore/raftex/RaftPart.cpp 71.21% <0.00%> (-0.94%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 87.39% <0.00%> (-0.87%) ⬇️
src/storage/admin/RebuildIndexTask.cpp 72.54% <0.00%> (-0.66%) ⬇️
src/kvstore/raftex/Host.cpp 71.70% <0.00%> (-0.65%) ⬇️
src/common/utils/IndexKeyUtils.h 90.57% <0.00%> (-0.56%) ⬇️
src/common/fs/test/FileUtilsTest.cpp 99.52% <0.00%> (-0.48%) ⬇️
src/storage/test/StatsTaskTest.cpp 94.61% <0.00%> (-0.45%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03605d0...a1a14df. Read the comment docs.

@Sophie-Xie Sophie-Xie merged commit 2e3b01a into vesoft-inc:master Apr 13, 2022
Sophie-Xie added a commit that referenced this pull request Apr 13, 2022
Sophie-Xie added a commit that referenced this pull request Apr 13, 2022
* Add SetUsageMessage For daemons (#4134)

* fix the wrong regex pattern of scientific notation (#4136)

* fix updatePart (#4139)

* fix updatePart

* fix format check

Co-authored-by: Sophie <[email protected]>

* show DATA_BALANCE in job list (#4138)

Co-authored-by: Sophie <[email protected]>

* fix disk fault recovery (#4131)

* fix disk fault recovery

* add ut

Co-authored-by: Sophie <[email protected]>

* Refactor findpath (#4095)

* optimize bfs

* optimizer allpath

* optimizer multi-shortestpath

* optimizer multi shortest path

* fix validate unit test

* add some comment

* fix error

* fix bfs error

* add comment

* delete conjunct

* add findpath unit test

* delete useless file

* delete log

* remove check

* multi thread executor

* single shortest multi thread

* add some testcases

* add gflags

* fix bfs error

* address comment

* Just report errorof property pruner in debug mode (#4142)

Co-authored-by: Sophie <[email protected]>

* remove Atomic Edge (#4127)

* try to remove Atomic Edge

* remove some space

* remove zone

Co-authored-by: Doodle <[email protected]>

* fix show tag/edge index status (#4148)

* fix multiple match (#4143)

Co-authored-by: Sophie <[email protected]>

* Refactor the process of symbols in optimizer. (#4146)

* Refactor the process of symbols in optimizer.

* Fix variable shadowing.

* Collect boundary from MatchResult directly.

* Check variable in TransformResult don't referenced by outside plan
nodes.

Co-authored-by: Sophie <[email protected]>

Co-authored-by: Alex Xing <[email protected]>
Co-authored-by: jie.wang <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: liwenhui-soul <[email protected]>
Co-authored-by: panda-sheep <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: shylock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants