Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when try lock raftLock, enable balance by experimental #4088

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

critical27
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

image

image

Crashed because we check the mutex whether is held. As for leader, sometimes, we could pass the check in commitRemovePeer, but we may fail in removePeer or updateQuorum.

How do you solve it?

Explicitly lock the function when necessary (as for leader). Follower don't need to lock it because the lock has already been acquired outside the function.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:
Not related

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Mar 28, 2022
@critical27 critical27 changed the title fix crash raftLock, enable balance by experimental fix crash when try lock raftLock, enable balance by experimental Mar 28, 2022
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 29, 2022
@Shinji-IkariG Shinji-IkariG merged commit 28c24fe into vesoft-inc:master Mar 30, 2022
@critical27 critical27 deleted the lock branch March 31, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants