Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3636 #3773

Closed
wants to merge 1 commit into from
Closed

fix #3636 #3773

wants to merge 1 commit into from

Conversation

jackwener
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: close #3636

Description:
#3636: detail

The bug: if all balance tasks success and the job is stopped before job status updated, the balance tasks will get muJobFinished_ through call back in the same thread

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jackwener jackwener added cherry-pick-v3.0 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test labels Jan 20, 2022
@Sophie-Xie Sophie-Xie linked an issue Jan 20, 2022 that may be closed by this pull request
liwenhui-soul
liwenhui-soul previously approved these changes Jan 20, 2022
@liwenhui-soul
Copy link
Contributor

job finish in another thread may be better than using recursive lock

@liwenhui-soul liwenhui-soul self-requested a review January 20, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

balance leader command keep running forever
3 participants