-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scan limit error more friendly. #3549
Make scan limit error more friendly. #3549
Conversation
Why do we need this limitation on vertex/edge scans when we already have slow query management? |
When executing query: | ||
""" | ||
MATCH (v:player{age:23}:bachelor) RETURN v | ||
""" | ||
Then a ExecutionError should be raised at runtime: Scan vertices must specify limit number. | ||
Then a ExecutionError should be raised at runtime: Scan vertices or edges need to specify a limit number, or limit number can not push down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These error messages are really not friendly and are implementation-specific.
It seems this scan limit error now overrides the index not existed case,
|
According to @CPWstatic 's suggestion, avoid user's mistake. |
…hancement/error-msg-more-friendly
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Close #3492
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: