Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify graph signal handler #3542

Merged
merged 14 commits into from
Dec 30, 2021
Merged

simplify graph signal handler #3542

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8ce57b9
simplify graph signal handler
heroicNeZha Dec 23, 2021
07d02ce
Merge remote-tracking branch 'origin/master' into graphd_block
heroicNeZha Dec 27, 2021
85896a6
style
heroicNeZha Dec 27, 2021
c77e135
style
heroicNeZha Dec 27, 2021
e8323eb
Merge branch 'graphd_block' of github.com:heroicNeZha/nebula into gra…
heroicNeZha Dec 27, 2021
7ba1b71
fix some comment
heroicNeZha Dec 28, 2021
edf9617
Merge branch 'master' into graphd_block
heroicNeZha Dec 28, 2021
ffab7f9
Merge branch 'master' into graphd_block
heroicNeZha Dec 28, 2021
2b199ab
Merge branch 'master' into graphd_block
yixinglu Dec 29, 2021
c7591eb
Merge branch 'master' into graphd_block
Sophie-Xie Dec 29, 2021
72a61fe
Merge branch 'master' into graphd_block
Sophie-Xie Dec 29, 2021
71e7bb2
Merge branch 'master' into graphd_block
Sophie-Xie Dec 29, 2021
ef36287
Merge branch 'master' into graphd_block
Sophie-Xie Dec 29, 2021
a0aa57f
Merge branch 'master' into graphd_block
Sophie-Xie Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/graph/service/GraphServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ bool GraphServer::start() {
int numThreads =
FLAGS_num_worker_threads > 0 ? FLAGS_num_worker_threads : gServer_->getNumIOWorkerThreads();
std::shared_ptr<apache::thrift::concurrency::ThreadManager> threadManager(
PriorityThreadManager::newPriorityThreadManager(numThreads, false /*stats*/));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating third party 3.0，newPriorityThreadManager remove second argument

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument affects the performance a lot, we must know how it behaves now. And make sure if it has another way to set the value. A benchmark must done for this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facebook/fbthrift@bfb527c?diff=split
Through this commit，thrift removed stats, and the function is the same as setting it to false

PriorityThreadManager::newPriorityThreadManager(numThreads));
threadManager->setNamePrefix("executor");
threadManager->start();

Expand Down