Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show local sessions command #3488

Merged
merged 10 commits into from
Dec 27, 2021
Merged

Add show local sessions command #3488

merged 10 commits into from
Dec 27, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Dec 16, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

  1. Add SHOW LOCAL SESSIONS command to list the sessions of the current graph node
  2. [Incompatibility] Deprecate SHOW ALL QUERIES. Now SHOW QUERIES lists all queries in the whole cluster and SHOW LOCAL QUERIES lists all queries in the current graph node.

Which issue(s)/PR(s) this PR relates to?

Depends on #3486
Close #3547

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Aiee Aiee added ready-for-testing PR: ready for the CI test incompatible PR: incompatible with the recently released version doc affected PR: improvements or additions to documentation wip Solution: work in progress labels Dec 16, 2021
@Aiee Aiee changed the title [WIP] Accommodate Session struct to GQL standard [WIP] Add show local sessions command Dec 17, 2021
@Aiee Aiee removed the wip Solution: work in progress label Dec 20, 2021
@Aiee Aiee changed the title [WIP] Add show local sessions command Add show local sessions command Dec 20, 2021
@Aiee Aiee requested review from CPWstatic and jievince December 20, 2021 06:25
@Aiee Aiee added the wip Solution: work in progress label Dec 20, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3488 (53ae557) into master (99f1f7a) will decrease coverage by 0.00%.
The diff coverage is 82.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3488      +/-   ##
==========================================
- Coverage   85.19%   85.19%   -0.01%     
==========================================
  Files        1304     1306       +2     
  Lines      121308   122181     +873     
==========================================
+ Hits       103352   104087     +735     
- Misses      17956    18094     +138     
Impacted Files Coverage Δ
src/clients/storage/StorageClient.h 100.00% <ø> (ø)
src/clients/storage/StorageClientBase-inl.h 75.12% <ø> (+2.44%) ⬆️
src/codec/RowWriterV2.h 94.44% <ø> (ø)
src/common/datatypes/Value.h 97.87% <ø> (ø)
src/common/time/TimeConversion.h 100.00% <ø> (ø)
src/common/utils/IndexKeyUtils.h 90.65% <0.00%> (-0.29%) ⬇️
src/graph/session/GraphSessionManager.cpp 76.50% <0.00%> (-4.29%) ⬇️
src/graph/session/GraphSessionManager.h 100.00% <ø> (ø)
src/graph/util/SchemaUtil.cpp 92.05% <0.00%> (-0.78%) ⬇️
src/graph/validator/MutateValidator.h 100.00% <ø> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af74bab...53ae557. Read the comment docs.

@Aiee Aiee removed the wip Solution: work in progress label Dec 23, 2021
@Sophie-Xie Sophie-Xie added ready for review type/enhancement Type: make the code neat or more efficient labels Dec 23, 2021
@jievince
Copy link
Contributor

Plz resolve the conflicts

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarrisChu
Copy link
Contributor

incompatible

SHOW QUERIES -> SHOW LOCAL QUERIES
SHOW ALL QUERIES -> SHOW QUERIES

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 544c86b into vesoft-inc:master Dec 27, 2021
@Aiee Aiee deleted the gql-session branch December 27, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation incompatible PR: incompatible with the recently released version ready for review ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add local scope command like SHOW LOCAL SESSIONS
6 participants