Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] storage may stuck, if we have kvstore operation while shutdown cluster #3358

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Nov 25, 2021

…hole cluster

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

plz see the issue below.

Which issue(s)/PR(s) this PR relates to?

#3353

@liuyu85cn liuyu85cn added the ready-for-testing PR: ready for the CI test label Nov 25, 2021
panda-sheep
panda-sheep previously approved these changes Nov 25, 2021
yixinglu
yixinglu previously approved these changes Nov 26, 2021
@yixinglu yixinglu added the type/bug Type: something is unexpected label Nov 26, 2021
@liuyu85cn liuyu85cn dismissed stale reviews from yixinglu and panda-sheep via 63219e6 November 26, 2021 08:52
@liuyu85cn liuyu85cn force-pushed the adjust-raft-service-stop branch from f7e3cf7 to 63219e6 Compare November 26, 2021 08:52
@codecov-commenter
Copy link

Codecov Report

Merging #3358 (64d8d0b) into master (a14d7b4) will decrease coverage by 0.02%.
The diff coverage is 69.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3358      +/-   ##
==========================================
- Coverage   85.25%   85.23%   -0.03%     
==========================================
  Files        1279     1276       -3     
  Lines      118989   118998       +9     
==========================================
- Hits       101445   101426      -19     
- Misses      17544    17572      +28     
Impacted Files Coverage Δ
src/graph/context/QueryContext.cpp 100.00% <ø> (ø)
src/graph/executor/mutate/DeleteExecutor.cpp 83.22% <ø> (ø)
src/graph/executor/mutate/InsertExecutor.cpp 100.00% <ø> (ø)
src/graph/executor/mutate/UpdateExecutor.cpp 87.64% <ø> (ø)
src/graph/executor/query/IndexScanExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/TraverseExecutor.h 100.00% <ø> (ø)
src/graph/service/GraphService.cpp 74.80% <ø> (ø)
src/graph/service/QueryEngine.h 100.00% <ø> (ø)
src/kvstore/raftex/RaftPart.cpp 71.54% <0.00%> (-1.51%) ⬇️
src/kvstore/raftex/RaftPart.h 98.30% <ø> (ø)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c3c2f...64d8d0b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants