-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify default session timeout #3357
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3357 +/- ##
==========================================
- Coverage 85.27% 85.24% -0.03%
==========================================
Files 1276 1277 +1
Lines 118999 119026 +27
==========================================
- Hits 101475 101468 -7
- Misses 17524 17558 +34
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could cleanup some logics about zero timeout handling.
c33024f
to
07bf8d4
Compare
after this pr, users should modify their configuration, i.e. change 0 to a valid value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What does this PR do?
session_idle_timeout_secs
andclient_idle_timeout_secs
from 0 (never timeout) to 28800(8 hours, which is also the default timeout MySQL uses).session_idle_timeout_secs
which checks the value when program starts and updating value. The valid range forsession_idle_timeout_secs
is [1, 604800]Which issue(s)/PR(s) this PR relates to?
Close #3305
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Incompatible: Users should modify their configuration, i.e. change 0 to a valid value after this PR is merged.
Ref: https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_wait_timeout
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: